Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add srl connectivity test #3056

Merged
merged 7 commits into from
Jul 20, 2023
Merged

add srl connectivity test #3056

merged 7 commits into from
Jul 20, 2023

Conversation

bobz965
Copy link
Collaborator

@bobz965 bobz965 commented Jul 19, 2023

What type of this PR

  • Tests

Which issue(s) this PR fixes:

Fixes #(issue-number)

WHAT

🤖 Generated by Copilot at 31e925f

This pull request improves the logging of the kube-ovn controller and ipam components, reduces the image size and build time of the kube-ovn images, and aligns the e2e testing framework with the Makefile. It modifies the files Makefile, pkg/controller/endpoint.go, pkg/controller/service.go, pkg/ipam/ipam.go, and test/e2e/framework/image.go.

🤖 Generated by Copilot at 31e925f

Sing, O Muse, of the mighty deeds of the kube-ovn heroes
Who tamed the network of the cloud with their skill and wisdom
And made their code more clear and swift with logs and constants
And shrank their images for testing with a base template

HOW

🤖 Generated by Copilot at 31e925f

  • Define a new variable KUBEOVN_BASE_IMG in the Makefile to build and load the base image for kube-ovn components (link)
  • Add a new line to the kind-load-image target in the Makefile to load the base image into the kind cluster nodes (link)
  • Add logging statements to the handleUpdateEndpoint function in pkg/controller/endpoint.go to print the information about the vips, backends and LBs that are updated or deleted in the OVN database (link,link)
  • Remove a commented out logging statement from the enqueueDeleteService function in pkg/controller/service.go to clean up the code (link)
  • Add a logging statement to the AllocateStatic function in pkg/ipam/ipam.go to print the information about the IP and the subnet that are allocated (link)
  • Add a new constant BaseImageTemplate to the test/e2e/framework/image.go file to define a template for the base image name (link)

@bobz965 bobz965 force-pushed the master branch 3 times, most recently from 8c94d9d to eefa3d5 Compare July 19, 2023 12:25
@zhangzujian
Copy link
Member

dist/images/kube-ovn should be removed.

@bobz965 bobz965 marked this pull request as ready for review July 20, 2023 02:15
@bobz965 bobz965 requested a review from zhangzujian July 20, 2023 02:15
@bobz965 bobz965 added the test automation tests label Jul 20, 2023
@bobz965
Copy link
Collaborator Author

bobz965 commented Jul 20, 2023

hi @zhangzujian , could you please help review?

@bobz965 bobz965 force-pushed the master branch 2 times, most recently from 7b048fe to 9e68cc8 Compare July 20, 2023 05:49
@bobz965 bobz965 merged commit 0d1599f into kubeovn:master Jul 20, 2023
zhangzujian added a commit to zhangzujian/kube-ovn that referenced this pull request Jul 21, 2023
* add srl connectivity test

* Update test/e2e/kube-ovn/switch_lb_rule/switch_lb_rule.go

---------

Co-authored-by: 张祖建 <[email protected]>
zhangzujian added a commit to zhangzujian/kube-ovn that referenced this pull request Jul 22, 2023
* add srl connectivity test

* Update test/e2e/kube-ovn/switch_lb_rule/switch_lb_rule.go

---------

Co-authored-by: 张祖建 <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
test automation tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants